Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DML validation to reject Bytes @id columns with SQL Server #8591

Closed
thebiglabasky opened this issue Aug 5, 2021 · 0 comments · Fixed by prisma/prisma-engines#2159
Closed

Add DML validation to reject Bytes @id columns with SQL Server #8591

thebiglabasky opened this issue Aug 5, 2021 · 0 comments · Fixed by prisma/prisma-engines#2159
Assignees
@pimeys
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: sql server Microsoft SQL Server
Milestone
2.30.0

Comments

@thebiglabasky
Copy link

Problem

We currently don't reject usage of Bytes as an ID column which isn't supported with SQL Server.

Suggested solution

Add validation to reject models making use of Bytes @id columns when the datasource provider is set to sqlserver.

Alternatives

Add support for index lengths so that users could refine the definition of the ID index and have SQL Server accept it.

Additional context

Internal discussion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pimeys pimeys

Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: sql server Microsoft SQL Server
Projects
None yet
Milestone
2.30.0
Development

Successfully merging a pull request may close this issue.

SQL Server: do not allow Bytes in @id prisma/prisma-engines
3 participants
@pimeys @janpio @thebiglabasky