Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client): happy blog-env test has no assertion #8613

Closed
Jolg42 opened this issue Aug 6, 2021 · 1 comment · Fixed by #13657
Closed

test(client): happy blog-env test has no assertion #8613

Jolg42 opened this issue Aug 6, 2021 · 1 comment · Fixed by #13657
Assignees
Labels
kind/tech A technical change. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: prisma-client topic: tests
Milestone

Comments

@Jolg42
Copy link
Member

Jolg42 commented Aug 6, 2021

This test has no assertion. adding "expect.assertions(1)" at the beginning makes the test fail.

https://github.com/prisma/prisma/blob/main/packages/client/src/__tests__/integration/happy/blog-env/test.ts

On first look, it looks like it's trying to test PrismaClientInitializationError but the code never errors.

We should check and properly test PrismaClientInitializationError

Context https://prisma-company.slack.com/archives/C016KUHB1R6/p1616400507047100

@danstarns
Copy link
Contributor

it is hard to tell what this test is testing, however, here I have added my best guess and ported the test to the new functional style #13657

@danstarns danstarns self-assigned this Jun 6, 2022
@Jolg42 Jolg42 added this to the 4.0.x milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech A technical change. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: prisma-client topic: tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants