Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling .catch() or .finally() on a prisma client model query does not fire the request in 2.29.0 #8718

Closed
millsp opened this issue Aug 12, 2021 · 3 comments · Fixed by #8720
Assignees
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/regression A reported bug in functionality that used to work before. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: prisma-client
Milestone

Comments

@millsp
Copy link
Member

millsp commented Aug 12, 2021

Bug description

await prisma.user.create({data: {email: 'test@test.io'}}).catch(() => {}) doesn't fire the request anymore in 2.29.0

How to reproduce

Expected behavior

No response

Prisma information

Environment & setup

  • OS:
  • Database:
  • Node.js version:

Prisma Version

2.29.0
@millsp millsp added kind/bug A reported bug. kind/regression A reported bug in functionality that used to work before. topic: prisma-client tech/typescript Issue for tech TypeScript. kind/tech A technical change. labels Aug 12, 2021
@millsp millsp self-assigned this Aug 12, 2021
@Jolg42 Jolg42 changed the title Calling catch on a prisma client promise does not fire the request Calling .catch() or .finally() on a prisma client model query does not fire the request Aug 12, 2021
@Jolg42 Jolg42 added this to the 2.30.0 milestone Aug 12, 2021
@Jolg42 Jolg42 changed the title Calling .catch() or .finally() on a prisma client model query does not fire the request Calling .catch() or .finally() on a prisma client model query does not fire the request in 2.29.0 Aug 12, 2021
@Jolg42 Jolg42 added the team/client Issue for team Client. label Aug 12, 2021
@janpio janpio added bug/2-confirmed Bug has been reproduced and confirmed. and removed kind/bug A reported bug. kind/tech A technical change. labels Aug 12, 2021
@PabloSzx
Copy link

is 2.29.1 going to be released with the fix of #8720?

@millsp
Copy link
Member Author

millsp commented Aug 12, 2021

Yes

@Jolg42
Copy link
Member

Jolg42 commented Aug 13, 2021

Fix now available in the 2.29.1 patch just released a minute ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/regression A reported bug in functionality that used to work before. team/client Issue for team Client. tech/typescript Issue for tech TypeScript. topic: prisma-client
Projects
None yet
4 participants