Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TLS by default on SQL Server #8863

Closed
pimeys opened this issue Aug 23, 2021 · 0 comments · Fixed by prisma/quaint#317
Closed

Enable TLS by default on SQL Server #8863

pimeys opened this issue Aug 23, 2021 · 0 comments · Fixed by prisma/quaint#317
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: sql server Microsoft SQL Server
Milestone
2.31.0 / 3.0.x

Comments

@pimeys
Copy link
Contributor

pimeys commented Aug 23, 2021

Currently when we do not set the encrypt parameter on SQL Server, our default is false, meaning we just set TLS on for login and after that everything else is plaintext.

I don't see any reason to have this default in 2021. The SQL Server has one of the simplest TLS setups and we should aim to use the more secure default and let the user to opt-out from that only if they know what they are doing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: sql server Microsoft SQL Server
Projects
None yet
Milestone
2.31.0 / 3.0.x
Development

Successfully merging a pull request may close this issue.

More secure SQL Server default TLS setting prisma/quaint
3 participants
@pimeys @Jolg42 @tomhoule