-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prisma 3.0.1
warns about breaking changes.
#9171
Comments
prisma 3.0.1
warns about breaking changes.prisma 3.0.1
does not warns about breaking changes.
I don't understand the title change. This is a clean/new install. It shouldn't warn about breaking changes at all. The original title was correct. Edit: Well, sure, the title change makes sense in the context of switching to semver, but the original report was because I got that message on a clean install. |
prisma 3.0.1
does not warns about breaking changes.prisma 3.0.1
warns about breaking changes.
This is what I am seeing on a clean install:
Is that what you are seeing as well @Zn4rK? |
@janpio Yep, exactly. |
Ok, so this is comparing the previous version in the project with the current version - and on a new project this now seems to return a number < 12 - which makes sense on Then we can additionally also think if we should output a warning that reminds people to look at the breaking changes in 3.x if they upgrade from 2.x. Does that make sense? |
Thanks for reporting this @Zn4rK - a draft PR is up and we are now looking at if this is all correct, covered, if we can and should do more and so on. The message is really nothing to worry about of course really. |
Sorry for the title change that I did. I misread the issue and thought you were asking for a warning about breaking changes. Looks like this is already handled now. |
Bug description
It probably should warn about breaking changes, but this check:
prisma/packages/cli/src/Generate.ts
Line 219 in 40783e1
Is not correct since the switch to semver.
How to reproduce
Install
prisma
@3.0.1
and re-runprisma generate
.Expected behavior
No response
Prisma information
Environment & setup
Prisma Version
The text was updated successfully, but these errors were encountered: