Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview feature feedback: referentialIntegrity #9380

Closed
Tracked by #11441
tomhoule opened this issue Sep 22, 2021 · 19 comments
Closed
Tracked by #11441

Preview feature feedback: referentialIntegrity #9380

tomhoule opened this issue Sep 22, 2021 · 19 comments
Assignees
Labels
kind/feedback Issue for gathering feedback. team/client Issue for team Client. team/schema Issue for team Schema. topic: previewFeatures Issue touches on an preview feature flag topic: referentialIntegrity/relationMode
Milestone

Comments

@tomhoule
Copy link
Contributor

Please share your feedback about the referentialIntegrity preview feature released in v3.1.1 in this issue.

  • If you encounter a bug, please open a bug report in this repo.
  • If the feature is working well for you, please share this in a comment below or leave a 👍 on this issue.

If you have any questions, don't hesitate to ask them in the #product-feedback channel in the Prisma Slack.

@tomhoule tomhoule added kind/feedback Issue for gathering feedback. topic: previewFeatures Issue touches on an preview feature flag team/schema Issue for team Schema. topic: referentialIntegrity/relationMode labels Sep 22, 2021
@2color

This comment has been minimized.

@SynergyEvolved
Copy link

Hi there,
I am curious as to why there is no mention of Vitess which is a CNCF graduated project, instead Prisma only mentions the commercial version of it Planetscale. https://www.prisma.io/docs/reference/database-reference/supported-databases#preview

@janpio
Copy link
Member

janpio commented Sep 24, 2021

Because no one ever asked to use Prisma with Vitess @SynergyEvolved, but many people asked for PlanetScale support (which is a specially configured deployment of Vitess with specific settings activated). We are partially testing on Vitess, but only with configuration that makes it PlanetScale like as well.

Please open an issue for explicit Vitess support and we can look into doing the work to confirm this fully working as well.

@do4gr do4gr assigned do4gr and floelhoeffel and unassigned do4gr Oct 21, 2021
@tastnt

This comment has been minimized.

@floelhoeffel

This comment has been minimized.

@pimeys

This comment has been minimized.

@guillaumervls

This comment has been minimized.

@janpio janpio added the team/client Issue for team Client. label Dec 2, 2021
@janpio

This comment was marked as outdated.

@niwatoliver
Copy link

I am using planetscale and the following error occurs when the number of data is large.

PrismaClientUnknownRequestError: 
Invalid `prisma.room.findMany()` invocation:


Error occurred during query execution:
ConnectorError(ConnectorError { user_facing_error: None, kind: QueryError(Server(ServerError { code: 1153, message: "rpc error: code = ResourceExhausted desc = grpc: received message larger than max (24831606 vs. 16777216)", state: "42000" })) })

I assume that this is probably caused by the use of IN clauses in the part of the query that should be issued with a JOIN.

await prisma.room.findMany({
        where: { status: NextAction.COMPLETE },
        include: { matches: true },
});

image

Currently I am using take and skip to work around this, but it would be great if you could fix this as a bug.

@Jolg42
Copy link
Member

Jolg42 commented Oct 17, 2022

Hi @minakawa-daiki Could you create an issue here?
If you could provide reproduction steps it would help a lot.

Note: This is maybe unrelated to the referentialIntegrity feature

@niwatoliver
Copy link

OK.
Please give me some time as I need a large amount of data to reproduce it.

@Jolg42
Copy link
Member

Jolg42 commented Nov 10, 2022

@minakawa-daiki did you get a chance to reproduce it?

@niwatoliver
Copy link

@Jolg42 Sorry. I have not taken the time to verify it by avoiding it in other ways.

@janpio janpio added this to the 4.7.0 milestone Nov 22, 2022
@pfried

This comment was marked as off-topic.

@Jolg42

This comment was marked as off-topic.

@pfried

This comment was marked as off-topic.

@pfried

This comment was marked as off-topic.

@Jolg42
Copy link
Member

Jolg42 commented Nov 24, 2022

@pfried I will mark these comments off topic for this issue, I created a separate issue based on your message here:
#16439

@janpio
Copy link
Member

janpio commented Nov 30, 2022

Thanks everyone for your feedback, Relation Mode (with preview feature referentialIntegrity went Generally Available with 4.7.0. Read more about it in the documentation: https://www.prisma.io/docs/concepts/components/prisma-schema/relations/relation-mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feedback Issue for gathering feedback. team/client Issue for team Client. team/schema Issue for team Schema. topic: previewFeatures Issue touches on an preview feature flag topic: referentialIntegrity/relationMode
Projects
None yet
Development

No branches or pull requests