Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of introspect crash #1728

Closed
Jolg42 opened this issue Feb 28, 2020 · 2 comments · Fixed by #1808
Closed

Better handling of introspect crash #1728

Jolg42 opened this issue Feb 28, 2020 · 2 comments · Fixed by #1808
Assignees
@timsuchanek @Jolg42
Labels
kind/improvement An improvement to existing feature and code. topic: prisma db pull CLI: prisma db pull
Milestone
Preview 24 Old

Comments

@Jolg42
Copy link
Member

Jolg42 commented Feb 28, 2020

Reproduction #1648

Current error
Screen Shot 2020-02-28 at 14 33 07

We should handle & output a better user facing error here.
@Jolg42 Jolg42 added kind/improvement An improvement to existing feature and code. topic: cli-introspect labels Feb 28, 2020
@Jolg42 Jolg42 added this to the Preview 23 milestone Feb 28, 2020
@janpio
Copy link
Member

janpio commented Feb 28, 2020

Especially the Error [ERR_STREAM_DESTROYED] ... thing should be caught and hidden.

@janpio janpio modified the milestones: Preview 23, Preview 24 Mar 3, 2020
Jolg42 added a commit that referenced this issue Mar 10, 2020
@Jolg42
fix(#1728) Handle disconnected error for introspection engine
3e3adcd
@Jolg42 Jolg42 linked a pull request Mar 10, 2020 that will close this issue
fix(#1728) Handle disconnected error for introspection engine #1808
Merged
timsuchanek added a commit that referenced this issue Mar 10, 2020
@timsuchanek
Merge pull request #1808 from prisma/introspection-handle-disconnected
701690f 
fix(#1728) Handle disconnected error for introspection engine
@janpio
Copy link
Member

janpio commented Mar 11, 2020 •
edited

So much better: https://github.com/prisma/introspection-engine-output/commit/79beb9033c9dcc41c2cf6765f5183136b4b678a6 - Thanks!

@janpio janpio added topic: prisma db pull CLI: prisma db pull and removed topic: prisma introspect labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timsuchanek timsuchanek

@Jolg42 Jolg42

Labels
kind/improvement An improvement to existing feature and code. topic: prisma db pull CLI: prisma db pull
Projects
None yet
Milestone
Preview 24 Old
Development

Successfully merging a pull request may close this issue.

fix(#1728) Handle disconnected error for introspection engine prisma/prisma
4 participants
@janpio @divyenduz @timsuchanek @Jolg42