Integration tests for SQLite and MySQL #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schema: `[\s\S\r]+?`,\n
|
🙌 🙌 🙌 🙌 🙌 🙌 |
|
@matthewmueller We really need to name these tests one day, do you think you could help with that? |
# Conflicts: # cli/prisma2/src/__tests__/integrate.postgresql.test.ts
This was
linked to
issues
Mar 9, 2020
|
For my understanding, do these tests line up exactly? For example, "test 10" in sqlite is the same as "test 10" in mysql? I'm wondering if we should stick all the database in the same file, so they don't drift. |
|
@matthewmueller We may want to reorganize the architecture at some point, right now they are copies so they follow the same order. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#1603
#1602
SQLite: ready but each test is slow and takes 3s
MySQL: ready!