Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Introspection] Comment out all unsupported column types #1812

Closed
janpio opened this issue Mar 10, 2020 · 0 comments · Fixed by prisma/prisma-engines#588
Closed

[Introspection] Comment out all unsupported column types #1812

janpio opened this issue Mar 10, 2020 · 0 comments · Fixed by prisma/prisma-engines#588
Assignees
Labels
kind/feature A request for a new feature. topic: client types Types in Prisma Client topic: introspection
Milestone

Comments

@janpio
Copy link
Member

janpio commented Mar 10, 2020

We now have a definitive list of column types we want to and can support in Prisma right now. Introspection should comment out all columns that use other column types as a guardrail. As usual, above the commented out field there should also be a comment that explains what is going on.

Preliminary list:

MySQL

smallint
int
bigint
decimal
float
double
boolean / tinyint(1)
date
datetime
timestamp
time
year
char
varchar
tinytext
text
mediumtext
longtext
enum
json

PostgreSQL

smallint | int2
integer | int, int4
bigint | int8
numeric(p,s) | decimal(p,s)
real | float, float4
double precision | float8
smallserial | serial2
serial | serial4
bigserial | serial8
money
character(n) | char(n)
character varying(n) | varchar(n)
text
timestamp without time zone | timestamp
timestamp with time zone | timestamptz
date
time without time zone | time
time with time zone | timetz
boolean | bool
enum
inet
bit(n)
bit varying(n)
uuid
json
jsonb
Array types

Original, internal source: https://www.notion.so/prismaio/Database-Types-19d73094f57a4b9dae576f37b1166d8f

Caution: Depending on implementation status, we might need to disable some of these types along the way temporarily. But for now we start with this list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature A request for a new feature. topic: client types Types in Prisma Client topic: introspection
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants