Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments in schema's datasource block fail with Error: Schema parsing error: Unexpected token. Expected one of: End of block ("}"), alphanumeric identifier #1905

Closed
Jolg42 opened this issue Mar 23, 2020 · 1 comment
Assignees
Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/regression A reported bug in functionality that used to work before.
Milestone

Comments

@Jolg42
Copy link
Member

Jolg42 commented Mar 23, 2020

Prisma CLI Version   : prisma2@2.0.0-alpha.944
Current platform     : darwin
Query Engine         : prisma e33c54faa0d656a9dd22546696753591a9c6d9d0 (at /Users/j42/.npm/_npx/1558/lib/node_modules/prisma2/query-engine-darwin)
Migration Engine     : migration-engine-cli e33c54faa0d656a9dd22546696753591a9c6d9d0 (at /Users/j42/.npm/_npx/1558/lib/node_modules/prisma2/migration-engine-darwin)
Introspection Engine : introspection-core e33c54faa0d656a9dd22546696753591a9c6d9d0 (at /Users/j42/.npm/_npx/1558/lib/node_modules/prisma2/introspection-engine-darwin)

The comment in the datasource block fails at validation:
Screen Shot 2020-03-23 at 14 02 28

schema.prisma

datasource db {
    provider = "postgresql"
    // Like, postgresql://user:password@localhost:5432/database/schema
    url      = "***"
}

With preview 23 it was working

npx prisma2@2.0.0-preview023 validate --schema=./schema.datasource.comment.prisma
The schema at /Users/j42/Dev/testinstall/schema.datasource.comment.prisma is valid 🚀
@Jolg42 Jolg42 added bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. labels Mar 23, 2020
@Jolg42 Jolg42 added this to the Preview 25 milestone Mar 23, 2020
@janpio janpio added kind/regression A reported bug in functionality that used to work before. and removed kind/bug A reported bug. labels Mar 23, 2020
@mavilein
Copy link
Member

This got fixed in prisma/prisma-engines@8cec25a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/regression A reported bug in functionality that used to work before.
Projects
None yet
Development

No branches or pull requests

3 participants