Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using svg breaks markeplace publish #157

Closed
carmenberndt opened this issue May 25, 2020 · 6 comments · Fixed by #200
Closed

Using svg breaks markeplace publish #157

carmenberndt opened this issue May 25, 2020 · 6 comments · Fixed by #200
Assignees
@carmenberndt
Labels
kind/improvement An improvement to existing feature and code.
Milestone
Beta 7

Comments

@carmenberndt
Copy link
Contributor

The marketplace badges for the current version, number of installs, rating, ... break marketplace publish.
@carmenberndt
Copy link
Contributor Author

The following badges would be nice to have again:

` Latest Release
Installs
Rating

CI tests
Check for Update + Automated Publish`

@janpio
Copy link
Member

janpio commented May 25, 2020

Solution: Have different READMEs for Marketplace and for GitHub.

@janpio janpio added the kind/improvement An improvement to existing feature and code. label May 25, 2020
@carmenberndt
Copy link
Contributor Author

This might only be a problem with the badge provider used. https://code.visualstudio.com/api/working-with-extensions/publishing-extension#publishing-extensions. Apparently having .svg files is possible in a README

@janpio
Copy link
Member

janpio commented May 28, 2020

github.com (the Github Action badges) is not on that list :(

@carmenberndt
Copy link
Contributor Author

github.com (the Github Action badges) is not on that list :(

But we can still use this as a workaround.

@janpio
Copy link
Member

janpio commented May 28, 2020

We should also all leave upvotes on microsoft/vscode-vsce#389

@carmenberndt carmenberndt mentioned this issue May 29, 2020
Merged
@carmenberndt carmenberndt self-assigned this May 29, 2020
@carmenberndt carmenberndt added this to the Beta 7 milestone May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmenberndt carmenberndt

Labels
kind/improvement An improvement to existing feature and code.
Projects
None yet
Milestone
Beta 7
Development

Successfully merging a pull request may close this issue.

improvement(README): Include badges again prisma/language-tools
2 participants
@janpio @carmenberndt