Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger CI tests after bumping the version and before publishing #197

Closed
carmenberndt opened this issue May 28, 2020 · 2 comments · Fixed by #202
Closed

Trigger CI tests after bumping the version and before publishing #197

carmenberndt opened this issue May 28, 2020 · 2 comments · Fixed by #202
Assignees
@carmenberndt
Labels
kind/improvement An improvement to existing feature and code. team/other Issue for another team that does not fit our nice boxes.
Milestone
2.1.0

Comments

@carmenberndt
Copy link
Contributor

carmenberndt commented May 28, 2020 •
edited

We want to run e2e tests for each commit, even for the ones from the CI.

Currently checking for updates, bumping the versions and publishing the extension happen in a single step in a job in a Github Action workflow. (for jobs publish and publish-dev)
(Note: for stable, bumping and publishing happens in memory (most changes are not committed to the repo)

Bumping the versions should be a separate step in the job, triggering the e2e tests and then publishing should happen via another step in the job.
@carmenberndt carmenberndt added the kind/improvement An improvement to existing feature and code. label May 28, 2020
@carmenberndt
Copy link
Contributor Author

carmenberndt commented May 28, 2020 •
edited

Next steps:
Write down the full solution first, to the exact step as a spec before implementing this.

@carmenberndt
Copy link
Contributor Author

carmenberndt commented May 28, 2020 •
edited

Step 1: check-update
This returns a boolean output describing if new updates are available or not.
Step 2: Bump versions
This only runs in case the output of check-update is true.
Changes are only committed for the unstable version.
Step 3: Run headless tests
This only runs in case the output of check-update is true.
Step 4: Publish Extension
This only runs in case the output of check-update is true.

@carmenberndt carmenberndt mentioned this issue May 29, 2020
Merged
@carmenberndt carmenberndt self-assigned this May 29, 2020
@carmenberndt carmenberndt added the process/candidate Candidate for next Milestone. label Jun 9, 2020
@janpio janpio added the team/other Issue for another team that does not fit our nice boxes. label Jun 10, 2020
@janpio janpio added this to the 2.1.0 milestone Jun 10, 2020
@janpio janpio removed the process/candidate Candidate for next Milestone. label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmenberndt carmenberndt

Labels
kind/improvement An improvement to existing feature and code. team/other Issue for another team that does not fit our nice boxes.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

improvement(CI): trigger CI tests after bumping versions and before publishing prisma/language-tools
2 participants
@janpio @carmenberndt