Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean build before publish #252

Closed
divyenduz opened this issue Jun 19, 2020 · 0 comments · Fixed by #262
Closed

Clean build before publish #252

divyenduz opened this issue Jun 19, 2020 · 0 comments · Fixed by #262
Assignees
@carmenberndt
Labels
kind/improvement An improvement to existing feature and code. topic: automation
Milestone
2.1.0

Comments

@divyenduz
Copy link

In prepublish script of TS projects, we should clean up the dist/out folders, so that a published extension is a clean build.

We did a manual publish for the extension 2.0.2 that had leftover binaries from development #251 and that led to binary mismatch on Linux #248

We didn't observe this before because other extension releases happened from CI which had a clean build history.
@divyenduz divyenduz added process/candidate Candidate for next Milestone. kind/improvement An improvement to existing feature and code. labels Jun 19, 2020
@divyenduz divyenduz mentioned this issue Jun 19, 2020
Closed
@carmenberndt carmenberndt self-assigned this Jun 22, 2020
@carmenberndt carmenberndt mentioned this issue Jun 22, 2020
Merged
@carmenberndt carmenberndt removed the process/candidate Candidate for next Milestone. label Jun 22, 2020
@carmenberndt carmenberndt added this to the 2.1.0 milestone Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carmenberndt carmenberndt

Labels
kind/improvement An improvement to existing feature and code. topic: automation
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

improvement(CI): clean build before publish prisma/language-tools
3 participants
@janpio @divyenduz @carmenberndt