Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Publishing] Send message to Slack channel on publish (success or failure) #76

Closed
janpio opened this issue Mar 25, 2020 · 2 comments · Fixed by #211
Closed

[Publishing] Send message to Slack channel on publish (success or failure) #76

janpio opened this issue Mar 25, 2020 · 2 comments · Fixed by #211
Assignees
Labels
kind/improvement An improvement to existing feature and code. team/other Issue for another team that does not fit our nice boxes. topic: automation
Milestone

Comments

@janpio
Copy link
Member

janpio commented Mar 25, 2020

https://github.com/prisma/vscode/blob/master/.github/workflows/publish.yml already automated publishing this extension, now we should also add something that notifies us. A Slack message should be a simple way to do that. (@steebchen already built that for something similar)

@janpio janpio added topic: automation kind/improvement An improvement to existing feature and code. labels Mar 25, 2020
@janpio janpio added the team/other Issue for another team that does not fit our nice boxes. label Apr 23, 2020
@janpio
Copy link
Member Author

janpio commented Apr 23, 2020

@steebchen can you link to some of the places where you implemented something like that so the person picking this up can see how this already works for us?

@steebchen
Copy link

GitHub Action workflow relevant lines:

https://github.com/prisma/prisma2-e2e-tests/blob/master/.github/workflows/test.yaml#L4-L18

This invokes this shell script: https://github.com/prisma/prisma2-e2e-tests/blob/master/.github/scripts/slack-workflow-status.sh
Which invokes this javascript file: https://github.com/prisma/prisma2-e2e-tests/blob/master/.github/slack/notify.js

(please also note that you need to have a package.json & lockfile in the js file directory https://github.com/prisma/prisma2-e2e-tests/tree/master/.github/slack and invoke yarn install to install these before executing the file)

I chose this over existing slack actions to be flexible. A simple existing GitHub community slack action might be enough depending on the use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. team/other Issue for another team that does not fit our nice boxes. topic: automation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants