feat: add CompilerConfigBuilder #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwkang1998
force-pushed
the
chen/config-builder
branch
from
7672f2d
to
421ca16
Compare
cwkang1998
force-pushed
the
chen/config-builder
branch
from
421ca16
to
2e6414c
Compare
leolara
force-pushed
the
main
branch
4 times, most recently
from
03ddbb5
to
8397503
Compare
|
This is very different from the requirements |
|
@leolara Can you point out what I should change to adhere to the requirements? I can attempt another implementation of this if you don't mind. If you have an example of the builder pattern implementation you want can you share it so that I may reference it as well? Thanks in advance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for a compiler config builder, currently attempted to implement according to a typed builder approach.
Quite new at rust, so if I am doing something terribly wrong please do point them out and I'll work on it!
Adding test in the next commit, feel free to review before that so that I could make the required modification as well.
Closes #109