Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize column placement for PIL backend #183

Open
qwang98 opened this issue Nov 22, 2023 · 0 comments
Open

Optimize column placement for PIL backend #183

qwang98 opened this issue Nov 22, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@qwang98
Copy link
Collaborator

qwang98 commented Nov 22, 2023

Currently, each signal has its own column, which does not save the number of columns the most efficiently. Optimization can go in two stages:

  1. Have # of columns == maximum # of signals for each step type. For example, step type 1 has signals a and b, step type 2 has signals a, c, and d, so max(2, 3) = 3, and we will have 3 columns, with some different signals sharing the same column across different steps. In our current implementation, we would have 4 columns corresponding to 4 signals, which is not the most column saving method. This should be quite doable.
  2. Further optimize and reduce the # of columns by using multiple rows for each step type. However, I'd point out that PIL only supports rotation of one (similar to our next for forward signals), and I'm not sure if this will work for step instances with multiple rows though. Therefore, this optimization would require some research to see if there's a possible implementation.
@qwang98 qwang98 added the enhancement New feature or request label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant