Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to LookupBuilder #93

Open
leolara opened this issue Aug 23, 2023 · 10 comments
Open

Add unit tests to LookupBuilder #93

leolara opened this issue Aug 23, 2023 · 10 comments
Assignees
@motemotech
Labels
gfi easy Easy good first issue good first issue Good for newcomers

Comments

@leolara
Copy link
Collaborator

leolara commented Aug 23, 2023

To structs in this file: https://github.com/privacy-scaling-explorations/chiquito/blob/main/src/frontend/dsl/lb.rs
@leolara leolara added good first issue Good for newcomers gfi easy Easy good first issue labels Aug 23, 2023
@trangnv trangnv self-assigned this Aug 23, 2023
@motemotech
Copy link

Hi, can I work on this issue?

@qwang98
Copy link
Collaborator

qwang98 commented Sep 11, 2023

@trangnv Still on this?

@trangnv
Copy link
Collaborator

trangnv commented Sep 11, 2023

@motemotech Yes you can work on this!

@leolara leolara assigned motemotech and unassigned trangnv Sep 13, 2023
@motemotech
Copy link

Hi, do you have any naming rules for branchs in this prj?

@leolara
Copy link
Collaborator Author

leolara commented Sep 19, 2023

@motemotech not really rules but we usually do githandle/something-meaningfull

@motemotech
Copy link

ok, gotcha.

@motemotech
Copy link

@leolara
Hi, I finally finished adding test, but seems I do not have permission to push my branch.
Could you add me as a member of this repository?

@leolara
Copy link
Collaborator Author

leolara commented Oct 2, 2023

You have to create a branch in your fork, and then submit a PR @motemotech

@motemotech
Copy link

@leolara
Hi! Sorry for being late.
Is this good?
#148

@leolara
Copy link
Collaborator Author

leolara commented Feb 20, 2024

@motemotech the PR has unsolved problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@motemotech motemotech

Labels
gfi easy Easy good first issue good first issue Good for newcomers
Projects
Chiquito 2024
Status: In review
Milestone
No milestone
Development

No branches or pull requests
4 participants
@leolara @trangnv @motemotech @qwang98