Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for Python #94

Open
leolara opened this issue Aug 23, 2023 · 7 comments
Open

Add unit tests for Python #94

leolara opened this issue Aug 23, 2023 · 7 comments
Labels
gfi intermediate Intermediate good first issue good first issue Good for newcomers

Comments

@leolara
Copy link
Collaborator

leolara commented Aug 23, 2023

Add necessary infrastructure for unit test in Python and write at least one unit test to show it works.

Add to github actions to avoid merging if the python tests do not pass.

@leolara leolara added the good first issue Good for newcomers label Aug 23, 2023
@leolara leolara added the gfi intermediate Intermediate good first issue label Aug 23, 2023
@indextree
Copy link
Contributor

Can I pick up this issue? If there are some supplementary materials for this issue, I'd like to take for them :)

@leolara
Copy link
Collaborator Author

leolara commented Sep 8, 2023

@trangnv are you working on this or I give it to @indextree ?

@trangnv
Copy link
Collaborator

trangnv commented Sep 8, 2023

Please go ahead and work on it @indextree
Thanks

@leolara leolara assigned indextree and unassigned trangnv Sep 9, 2023
@leolara
Copy link
Collaborator Author

leolara commented Sep 9, 2023

@indextree so perhaps you can do this in several PRs, like chose a component and send a PR with unit tests for that one.

@indextree
Copy link
Contributor

@leolara Thanks. For which python code should I write unit test? Sorry for the late reply, because I thought I should write all unit test code for python frontend source. Can I write unit test code simply from fibonacci example?

@qwang98
Copy link
Collaborator

qwang98 commented Sep 17, 2023

I think it's basically for all the Python frontend source and that's why it can be in several PRs.

What do you mean "write from fibonacci example"? @indextree

@indextree
Copy link
Contributor

@qwang98 Oh I misunderstood. Thanks for the reply. Please just ignore that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gfi intermediate Intermediate good first issue good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

4 participants