Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an assertion to prevent dynamic lookups without selectors/fixed #224

Open
CPerezz opened this issue Nov 2, 2023 · 2 comments · May be fixed by #347
Open

Add an assertion to prevent dynamic lookups without selectors/fixed #224

CPerezz opened this issue Nov 2, 2023 · 2 comments · May be fixed by #347
Assignees
@CPerezz
Labels
enhancement New feature or request

Comments

@CPerezz
Copy link
Member

CPerezz commented Nov 2, 2023

This would prevent errors like PSE-ZKEVM dynamic lookups to happen unnoticed.
@CPerezz CPerezz added the enhancement New feature or request label Nov 2, 2023
@CPerezz CPerezz self-assigned this Nov 2, 2023
@davidnevadoc
Copy link

Can you provide some explanation/ example of this error @CPerezz ? Thanks!

@jonathanpwang
Copy link

Here is an example: the diff of the PR shows what changed, and there is a RAM example test. axiom-crypto/halo2-lib#206

@guorong009 guorong009 linked a pull request Jun 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPerezz CPerezz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add assertion for dynamic lookup privacy-scaling-explorations/halo2
3 participants
@davidnevadoc @jonathanpwang @CPerezz