Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the user choose the FloorPlanner? #250

Open
ed255 opened this issue Jan 16, 2024 · 0 comments
Open

Let the user choose the FloorPlanner? #250

ed255 opened this issue Jan 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ed255
Copy link
Member

ed255 commented Jan 16, 2024

The halo2 original implementation forces the circuit developer to choose a FloorPlanner when implementing the Circuit trait.
Should we change the API so that the user of the circuit can choose the FloorPlanner?
Discussion from #243 (comment)

I personally think the current API is fine becaue the circuit developer may have insights on what's the best FloorPlanner for their circuit.
@ed255 ed255 added the enhancement New feature or request label Jan 16, 2024
@ed255 ed255 mentioned this issue Jan 16, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ed255