Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testool] Potential improvement #1771

Open
ChihChengLiang opened this issue Feb 16, 2024 · 2 comments
Open

[testool] Potential improvement #1771

ChihChengLiang opened this issue Feb 16, 2024 · 2 comments
Labels
good first issue Good for newcomers T-feature Type: new features

Comments

@ChihChengLiang
Copy link
Collaborator

ChihChengLiang commented Feb 16, 2024

Describe the feature you would like

Potential improvement 1: Make it works on the root directory.

Currently, the testool requires the user to cd into the directory to work, which is a little bit annoying. The reason that the change of directory is required is that it depends on file paths like tests/, codehash.txt, and Config.toml.

Potential improvement 2: reproducible script on testool report website

The report is on this website: http://testool-public.s3-website.eu-central-1.amazonaws.com/nightly.1708040362.cd5edab.html. It would be great we can copy-paste a command on the website to reproduce the error.

Potential improvement 3: Simply the suite

I am not sure what was the purpose of the distinction between the default and the nightly suite. I tried to reproduce a panic without specifying the --suite but it failed to find the test_id, which is located in the nightly suite.

Additional context

No response

@ChihChengLiang ChihChengLiang added the T-feature Type: new features label Feb 16, 2024
@hero78119
Copy link
Member

hero78119 commented Feb 20, 2024

Another Potential improvement 4: report link support HTML hash tag

format: :

e.g.

http://testool-public.s3-website.eu-central-1.amazonaws.com/nightly.1708040362.cd5edab.html#invalidAddr_d54(ok)_g0_v0%23tests%2Fsrc%2FGeneralStateTestsFiller%2FstBadOpcode%2FinvalidAddrFiller.yml

So when raise issue we can easily target which test are targetting from the link

@ChihChengLiang
Copy link
Collaborator Author

Sounds like a great idea! A html anchor would be super helpful!

@ChihChengLiang ChihChengLiang added the good first issue Good for newcomers label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers T-feature Type: new features
Projects
None yet
Development

No branches or pull requests

2 participants