Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for the green ring and fix #460

Closed
franciscawijaya opened this issue Apr 29, 2024 · 14 comments
Closed

Check for the green ring and fix #460

franciscawijaya opened this issue Apr 29, 2024 · 14 comments
Assignees
Labels
bug Something isn't working

Comments

@franciscawijaya
Copy link
Member

Reference: similar to issue #340

Action plan:

  • take a fresh browser (both chrome and firefox) and install the extension
  • pick 100 random sites from the sample (in the crawler repo) and go to random.org
  • manually check if they have the green ring and then make a list of it.
  • check the google developer tools (fn F12 -> console) for error content message like content security policy prevented (like attached)
Screenshot 2024-04-29 at 10 20 09 AM
@franciscawijaya franciscawijaya self-assigned this Apr 29, 2024
@katehausladen
Copy link
Member

site list: https://github.com/privacy-tech-lab/gpc-web-crawler/blob/main/selenium-optmeowt-crawler/full-crawl-set.csv

@SebastianZimmeck SebastianZimmeck added analysis Privacy analysis components exploration Explore adding a feature etc. labels Apr 29, 2024
@franciscawijaya
Copy link
Member Author

franciscawijaya commented May 6, 2024

This checklist is for both Chrome and Firefox:
Notes:

@franciscawijaya
Copy link
Member Author

franciscawijaya commented May 6, 2024

Attached is the difference of the developer tools' console for Chrome and Firefox for specifically yourdictionary.com

Something notable is on Chrome, the console showed 'Third-party cookie will be blocked' for yourdictionary.com, just like the other websites. However, there is no green ring.

Screenshot 2024-05-05 at 9 18 43 PM Screenshot 2024-05-05 at 9 42 24 PM

@SebastianZimmeck
Copy link
Member

Thanks, @franciscawijaya.

pick 100 random sites from the sample (in the crawler repo) and go to random.org

Well, random.org was for selecting the 100 random sites. :)

I manually searched up the website (eg. incontrol clothing)

What do you mean by "incontrol clothing"?

Which version of OptMeowt did you use? The problem does not seem to be with the current version in the stores but with @OliverWang13's and @Mattm27's mv3 version (branch 350-1 or branch 350-2; @OliverWang13 and @Mattm27, which branch should be used actually?).

@franciscawijaya
Copy link
Member Author

franciscawijaya commented May 6, 2024

What do you mean by "incontrol clothing"?

Some sites changed their name so I just manually searched the updated name

Which version of OptMeowt did you use? The problem does not seem to be with the current version in the stores but with @OliverWang13's and @Mattm27's mv3 version (branch 350-1 or branch 350-2; @OliverWang13 and @Mattm27, which branch should be used actually?).

I loaded unpacked extension for version 4.3.1. I think it was branch 350-1.

@SebastianZimmeck
Copy link
Member

URL Chrome Firefox
url blah

(Just a sample to modify)

@franciscawijaya will check again using branch 350-5.

@franciscawijaya
Copy link
Member Author

Check if that version would work for a good percentage of sites. If not, contact Oliver & Matt.

@SebastianZimmeck
Copy link
Member

@franciscawijaya, to get the most recent versions, you can do:

For Firefox: git checkout issue-350-5.

For Chrome: git checkout 13c0f830011ef9ed72dddf16b16b3e533b7abae7 (the currently latest commit reference).

Then, you can check with git status that you are on those branches and, if so, follow the normal setup procedure.

@franciscawijaya
Copy link
Member Author

franciscawijaya commented May 13, 2024

*URL Chrome Firefox*
https://bdcnetwork.com
https://gazelle.com
https://thredup.com
https://toasttab.com
https://thedelite.com
https://nwaonline.com
https://vivint.com
https://vineyardvines.com
https://inboxdollars.com
https://genealogy.com
https://techlicious.com
https://big12sports.com
https://metro-magazine.com
https://kalashnikov-usa.com
https://facetory.com
https://wwbw.com
https://shopversona.com
https://peacecenter.org
https://atcc.org
https://commercebank.com
https://blog.educreations.com
https://chaosium.com
https://openvpn.net
https://josbank.com
https://granicus.com
https://niketalk.com
https://zurichna.com
https://sacred-texts.com
https://postermywall.com
https://galactictoys.com
https://rubytuesday.com
https://postscanmail.com
https://viewsonic.com
https://kivitv.com
https://everaccountable.com
https://alltribes.com
https://fredmeyer.com
https://myfwc.com
https://icq.com
https://autodiscover.patientslikeme.com
https://azdailysun.com
https://betterhelp.com
https://elitetraveler.com
https://minitab.com
https://cbs19news.com
https://powernationtv.com
https://thetrumpet.com
https://gointothestory.blcklst.com
https://unboundmedicine.com
https://redwoodcu.org
https://ritathletics.com
https://donatelife.net
https://merck.com
https://schneider.com
https://members.nysba.org
https://ellaclaireinspired.com
https://nexternal.com
https://evo.com
https://speedify.com
https://neilpatel.com
https://signal.org
https://intrustbank.com
https://dailybulletin.com
https://boingboing.net
https://megapath.com
https://revinate.com
https://biblestudytools.com
https://membership.aaep.org
https://rosebowlstadium.com
https://staterbros.com
https://usedvending.com
https://joovv.com
https://imagequix.com
https://mylocker.net
https://quickcountry.com
https://visitidaho.org
https://hbcugameday.com
https://cupertino.org
https://nissinfoods.com
https://lww.com
https://enchroma.com
https://multitracks.com
https://phs.org
https://directory.sway.com
https://lillypulitzer.com
https://gcfglobal.org
https://ria.com
https://crackle.com
https://pledge.com
https://synchronyfinancial.com
https://impacthub.net
https://dickinson-wright.com
https://sumerianrecords.com
https://inrix.com
https://lifeandscience.org
https://chatsworth.com
https://store.chatwork.com
https://genstattu.com
https://alzheimersnewstoday.com
https://foodbankheartland.org

All sample sites have green ring! Github on Firefox has green ring; only github on Chrome does not.

@SebastianZimmeck
Copy link
Member

Great! Feel free to close any issue once it is done, @franciscawijaya.

@SebastianZimmeck SebastianZimmeck changed the title Check for the green ring Check for the green ring and fix May 24, 2024
@SebastianZimmeck
Copy link
Member

SebastianZimmeck commented May 24, 2024

Reopening. Seems v5.0.0 for Firefox does not have the green ring and is also not sending the GPC signal properly.

@SebastianZimmeck SebastianZimmeck added bug Something isn't working and removed analysis Privacy analysis components exploration Explore adding a feature etc. labels May 24, 2024
@franciscawijaya
Copy link
Member Author

Screenshot 2024-05-23 at 8 46 26 PM

According to the browser developer tools, there currently is an xml parsing error. Potentially concerning the xml syntax in the new updated version?

It is also worth to note that the "cookie-test" being rejected for invalid domain; though, this could maybe come from the underlying xml parsing error.

@franciscawijaya
Copy link
Member Author

the xml parsing error seems to be from from Permutive so that actually does not have any correlation with the extension.

@SebastianZimmeck
Copy link
Member

As @Mattm27 found, the issue after re-opening was related to the dist manifests being outdated; only the dev manifests were updated after the switch to mv3. v5.0.1 fixes this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants