Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rm -rf to dist folder #11

Closed
ayuhito opened this issue Jun 28, 2022 · 6 comments · Fixed by #66
Closed

Include rm -rf to dist folder #11

ayuhito opened this issue Jun 28, 2022 · 6 comments · Fixed by #66
Labels

Comments

@ayuhito
Copy link
Contributor

ayuhito commented Jun 28, 2022

The dist folder end up becoming very polluted at times, especially when you delete a source file which still leaves its bundled-up counterpart in the dist folder. Either cleaning up the dist folder by default or including a --clean flag would be a nice QOL addition.

(Btw, I am happy to make some PRs in the near future for some of these issues I'm making - imo this bundler is the most ideal one out of others I've seen and I'm working on integrating it into the Fontsource project).

@privatenumber
Copy link
Owner

--clean-dist flag sounds good to me!

@privatenumber privatenumber added enhancement New feature or request pr welcome labels Jun 28, 2022
@ayuhito
Copy link
Contributor Author

ayuhito commented Jun 28, 2022

I was working on this but privatenumber/lintroll#33 is a blocker. Will wait till that's resolved!

@privatenumber
Copy link
Owner

Feel free to commit with linting violations via --no-verify.

@muratgozel
Copy link
Contributor

hey hey, i need this too, will you send a pr @ayuhito ? i can figure if you arent able to. and if you still okay with this @privatenumber

@ayuhito
Copy link
Contributor Author

ayuhito commented May 15, 2024

hey hey, i need this too, will you send a pr @ayuhito ?

Unfortunately, I don't have the bandwidth to work on this myself (I haven't touched TypeScript in a while). 👍

@privatenumber
Copy link
Owner

🎉 This issue has been resolved in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants