Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default target to LTS #13

Open
ayuhito opened this issue Jun 28, 2022 · 2 comments · May be fixed by #20
Open

Change default target to LTS #13

ayuhito opened this issue Jun 28, 2022 · 2 comments · May be fixed by #20
Labels
enhancement New feature or request pr welcome

Comments

@ayuhito
Copy link
Contributor

ayuhito commented Jun 28, 2022

I think having the default target to be reliant on process.versions.node creates a lot of inconsistency especially if you use a multitude of environments such as local and CI.

To fit closer to the paradigm of zero-config, it might be better for the bundler to default to Node LTS instead for best practices.

I'm not sure if this should be considered a breaking change considering the existing setup already led to inconsistent bundles.

@privatenumber
Copy link
Owner

I'm OK with that but we'll need a trusted API to get the latest Node version. Ideally an npm package that contains Node.js versions or something so that there's no loading time during build.

@privatenumber privatenumber added enhancement New feature or request pr welcome labels Jun 28, 2022
@ayuhito
Copy link
Contributor Author

ayuhito commented Jun 28, 2022

Isn't it just changing this line here from node${process.versions.node} to node14. Or am I missing something here? I'll be happy to PR it just to start getting my hands involved with this repo if that's the case.

I do think we should manually set the target and update the LTS target versions ourselves, so every time the default target changes we can mark it as a breaking change.

@ayuhito ayuhito linked a pull request Jul 19, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pr welcome
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants