Skip to content

Commit 02d3856

Browse files
authoredJun 8, 2024
fix(cjs): resolve directory import relative to parent (#42)
fixes #583
1 parent 89621bf commit 02d3856

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed
 

‎src/cjs/api/module-resolve-filename.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ export const createResolveFilename = (
164164
*/
165165
const resolved = (
166166
tryExtensions(resolve, possiblePath)
167-
|| tryExtensions(resolve, path.resolve(possiblePath, 'index'))
167+
|| tryExtensions(resolve, `${request}${path.sep}index`)
168168
);
169169
if (resolved) {
170170
return resolved + query;
@@ -187,7 +187,8 @@ export const createResolveFilename = (
187187
} catch (error) {
188188
const resolved = (
189189
tryExtensions(resolve, request)
190-
|| tryExtensions(resolve, path.resolve(request, 'index'))
190+
// Default resolve handles resovling paths relative to the parent
191+
|| tryExtensions(resolve, `${request}${path.sep}index`)
191192
);
192193
if (resolved) {
193194
return resolved + query;

‎tests/fixtures.ts

+3
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,9 @@ export const files = {
136136
${syntaxLowering}
137137
${preserveName}
138138
export const cjsContext = ${cjsContextCheck};
139+
140+
// Implicit directory import works outside of immedaite CWD child
141+
import '../ts/'
139142
`,
140143

141144
'json/index.json': JSON.stringify({ loaded: 'json' }),

0 commit comments

Comments
 (0)
Please sign in to comment.