Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues-433 #520

Closed
wants to merge 1 commit into from
Closed

fix issues-433 #520

wants to merge 1 commit into from

Conversation

cenfun
Copy link
Contributor

@cenfun cenfun commented Apr 5, 2024 •
edited

fix #433

before

------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------------|---------|----------|---------|---------|-------------------
All files               |     100 |      100 |     100 |     100 | 
 tsx-coverage-issue     |     100 |      100 |     100 |     100 | 
  index.ts              |     100 |      100 |     100 |     100 | 
 tsx-coverage-issue/bin |     100 |      100 |     100 |     100 | 
  test.ts               |     100 |      100 |     100 |     100 | 
------------------------|---------|----------|---------|---------|-------------------

after

------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------------------|---------|----------|---------|---------|-------------------
All files               |   88.23 |      100 |   66.66 |   88.23 | 
 tsx-coverage-issue     |   71.42 |      100 |   66.66 |   71.42 | 
  index.ts              |   71.42 |      100 |   66.66 |   71.42 | 6-7
 tsx-coverage-issue/bin |     100 |      100 |     100 |     100 | 
  test.ts               |     100 |      100 |     100 |     100 | 
------------------------|---------|----------|---------|---------|-------------------

@privatenumber
Copy link
Owner

Can you add a concise test to verify coverage works?

@cenfun
Copy link
Contributor Author

cenfun commented Apr 5, 2024

@privatenumber I'm afraid I can't, the tsx tests cannot run properly on my local machine. I'm using Windows 10, and there are some errors that I can't fix.

@privatenumber
Copy link
Owner

You can comment them out during development. Or you can use GitHub Actions on your fork branch.

@privatenumber privatenumber deleted the branch privatenumber:develop April 26, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverage with c8 and tsx reporting as 100% since version 4.3.0
2 participants
@cenfun @privatenumber