Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting rid of action/cache for release.yml #108

Open
oscard0m opened this issue Jul 5, 2021 · 1 comment
Open

Getting rid of action/cache for release.yml #108

oscard0m opened this issue Jul 5, 2021 · 1 comment

Comments

@oscard0m
Copy link
Contributor

oscard0m commented Jul 5, 2021

After adding cache option to setup-node, would have sense to remove this step?

- uses: actions/cache@v1
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-

@oscard0m oscard0m changed the title Getting rid of action/cache Getting rid of action/cache for release.yml Jul 5, 2021
@gr2m
Copy link
Contributor

gr2m commented Jul 5, 2021

I say yes. In the script, I'd check for a step with a uses key that starts with actions/cache and with.path being set to ~/.npm. If it matches, remove the step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants