Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't actually work with JSON? #90

Open
ScottChapman opened this issue May 25, 2021 · 0 comments
Open

Doesn't actually work with JSON? #90

ScottChapman opened this issue May 25, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@ScottChapman
Copy link

So I wanted to use JSON (since it looks like there is support) for my configuration files, but it doesn't look like there is any attempt to parse the JSON. See
https://github.com/probot/octokit-plugin-config/blob/main/src/util/get-config-file.ts#L72-L77

At this point the data IS the contents of the file, and is a serialized JSON object. It just isn't getting parsed.

Will convert my work to YAML for now, but thought this should get fixed (looks like the test is assuming what gets returned is the JSON, not raw which is in the request)

@ScottChapman ScottChapman added the bug Something isn't working label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant