Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily scheduled TravisCI build no longer runs #369

Closed
robvanderleek opened this issue Jun 30, 2021 · 11 comments
Closed

Daily scheduled TravisCI build no longer runs #369

robvanderleek opened this issue Jun 30, 2021 · 11 comments

Comments

@robvanderleek
Copy link
Contributor

The daily scheduled CI build in TravisCI no longer runs since building on travis-ci.org is ceased.

image

@gr2m
Copy link
Contributor

gr2m commented Jun 30, 2021

if anyone would you like to replace the travis setup with GitHub Actions that'd be great

@robvanderleek
Copy link
Contributor Author

I tried a straightforward migration from TravisCI to GH Actions in this PR: #370

My Ruby experience is little to none, the actual builds still fail and I'm not sure if I can test cron scheduled jobs in a fork but I guess we need to start somewhere. Can you take a look @gr2m ?

@gr2m
Copy link
Contributor

gr2m commented Jul 1, 2021

done via #370. The tests are failing and I see 308 responses in there? I don't even know what that means 🤷🏼

@robvanderleek
Copy link
Contributor Author

The 308s (had to look it up too of course) are caused by a permanent redirect from the now.sh domain URLs to the vercel.app domain.
I've replaced now.sh with vercel.app in this draft PR. Unfortunately a large amount of the Apps that failed with 308 now fail with 404, I guess because they are permanently down.

Any advice how to proceed?

@gr2m
Copy link
Contributor

gr2m commented Jul 1, 2021

I guess because they are permanently down

If I recall correctly, lots of the apps have not been working before, or they have been moved to a serverless environment without implementing the GET ping route. At some point it would be good to triage all the apps, but I think we should wait for @AaronDewes's pull request #367

@robvanderleek
Copy link
Contributor Author

Lots of the Apps that fail the ping check also give a 404 on the root URL. Makes sense to do a cleanup after #367 is merged 👍

A thing that still bothers me: I can't figure out why the daily scheduled workflow isn't running. I use a similar scheduled workflow in my own App repo. Does something perhaps needs to be enabled in the Actions part of the repo settings for the scheduled workflow to run?

@gr2m
Copy link
Contributor

gr2m commented Jul 2, 2021

it is running from what I can see?
https://github.com/probot/probot.github.io/actions/runs/992808934

Or am I missing something?

GitHub
This is the home of probot documentation, apps, how-to guides and more. - probot/probot.github.io

@AaronDewes
Copy link
Member

AaronDewes commented Jul 5, 2021

Fixed by #367 and #370, so I guess this can be closed.

@robvanderleek
Copy link
Contributor Author

Nice, the numbers for my app are up-to-data again, also hello dark mode.

The ordering on the landing page used to be based on number of installations, now it appears to be reversed alphabetically.
Not sure how the ordering should be though.

@AaronDewes
Copy link
Member

I guess I'll have to fix that too, sorry about that

@robvanderleek
Copy link
Contributor Author

Hi @AaronDewes

Thanks! New design looks great!

Rob

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants