fix(typescript): add done callback to Paginate interface

probot · Oct 30, 2019 · 3053278 · 3053278
1 parent 56415e9
commit 3053278
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/github/index.ts b/src/github/index.ts
@@ -64,7 +64,7 @@ export interface OctokitError extends Error {
 interface Paginate extends Octokit.Paginate {
   (
     responsePromise: Promise<Octokit.AnyResponse>,
-    callback?: (response: Octokit.AnyResponse) => any
+    callback?: (response: Octokit.AnyResponse, done: () => void) => any
   ): Promise<any[]>
 }
 

diff --git a/src/github/pagination.ts b/src/github/pagination.ts
@@ -14,7 +14,7 @@ export function addPagination (octokit: Octokit) {
   )
 }
 
-const defaultCallback = (response: Octokit.AnyResponse, done?: () => void) => response
+const defaultCallback = (response: Octokit.AnyResponse, done: () => void) => response
 
 async function paginate (octokit: Octokit, octokitPaginate: Octokit.Paginate, ...args: any[]) {
   // Until we fully deprecate the old paginate method, we need to check if the