Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error message on wrong pem error #1465

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Enhance error message on wrong pem error #1465

merged 1 commit into from
Jan 20, 2021

Conversation

eXpire163
Copy link
Contributor

The invalid pem message can appear, when the pem is corrent but only the app_id is wrong. This could come from an reinstalltion of the app or migrating from local to prod.

@eXpire163 eXpire163 requested a review from a team as a code owner January 20, 2021 15:47
@welcome
Copy link

welcome bot commented Jan 20, 2021

Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@eXpire163
Copy link
Contributor Author

Thanks for the feedback, added it in and even got the "Semantic" check to pass ;)

Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@gr2m gr2m merged commit 5f1831b into probot:master Jan 20, 2021
@welcome
Copy link

welcome bot commented Jan 20, 2021

Thanks for your contribution to probot! 🎉
Congrats!

@github-actions
Copy link

🎉 This PR is included in version 11.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants