Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(website): 11ty support #1516

Merged
merged 2 commits into from Jul 3, 2021
Merged

feat(website): 11ty support #1516

merged 2 commits into from Jul 3, 2021

Conversation

AaronDewes
Copy link
Member

@AaronDewes AaronDewes commented Apr 26, 2021 •
edited by markdownify bot

This breaks Jekyll, so when it's merged, directly after that, probot/probot.github.io#367 needs to update the submodule and be merged, because otherwise, automatic sync may happen and the build breaks.

View rendered docs/README.md
View rendered docs/development.md

@AaronDewes AaronDewes requested a review from a team as a code owner April 26, 2021 07:50
@AaronDewes AaronDewes changed the title Add 11ty support feat(website): 11ty support Apr 26, 2021
@AaronDewes AaronDewes mentioned this pull request Apr 26, 2021
Merged
@AaronDewes AaronDewes force-pushed the 11ty-support branch 2 times, most recently from 35293eb to 26aec7f Compare April 26, 2021 08:18
@gr2m
Copy link
Contributor

gr2m commented Apr 26, 2021

are both this PR and probot/probot.github.io#367 ready? I can take care of getting it merged today during pacific time evening hours

@AaronDewes
Copy link
Member Author

No, I haven't gotten the documentation to work (ToC is still missing, next button doesn't work), but I'll tell you once it's ready.

@gr2m
Copy link
Contributor

gr2m commented Jun 17, 2021

Hey @AaronDewes I see you pushed more updates since my last comment. Is there anything left to do from your side?

@AaronDewes
Copy link
Member Author

Sorry, I kinda forgot about this PR 😅. It'll be finished soon.

@AaronDewes
Copy link
Member Author

AaronDewes commented Jul 2, 2021 •
edited by unfurl-links bot

@gr2m Please check out https://probot-testsite.github.io/

@gr2m
Copy link
Contributor

gr2m commented Jul 2, 2021 •
edited by unfurl-links bot

woohooo looking great!!

I've tested the site a bit and I found

image

- The styling of the https://probot-testsite.github.io/community/ page is a bit off compared to https://probot.github.io/community/

Other than the sidebar links I don't mind creating follow up links for the others though and move forward with 11ty!

@AaronDewes
Copy link
Member Author

I fixed it now, the fix should be online in a few minutes

@AaronDewes
Copy link
Member Author

AaronDewes commented Jul 2, 2021 •
edited

When mergin this, remember to change the Github Pages branch to gh-pages in the repo settings of the web page repo

gr2m
gr2m approved these changes Jul 3, 2021
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooo

@gr2m gr2m merged commit 7a43e9e into probot:master Jul 3, 2021
@github-actions
Copy link

github-actions bot commented Jul 3, 2021

🎉 This PR is included in version 12.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@johnperez416 johnperez416 mentioned this pull request Sep 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AaronDewes @gr2m