Add support to pass, as env variable, the org name for app creation manifest flow #1606
Conversation
|
Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved. |
docs/configuration.md
Outdated
| @@ -23,6 +23,7 @@ Some less common environment variables are: | |||
| | --------------------- | --------------------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | |||
| | `GHE_HOST` | `new Probot({ Octokit: ProbotOctokit.defaults({ baseUrl }) })` | The hostname of your GitHub Enterprise instance. <p>_(Example: `github.mycompany.com`)_</p> | | |||
| | `GHE_PROTOCOL` | `new Probot({ Octokit: ProbotOctokit.defaults({ baseUrl }) })` | The protocol of your GitHub Enterprise instance. Defaults to HTTPS. Do not change unless you are certain. <p>_(Example: `https`)_</p> | | |||
| | `GHE_ORG` | - | The organization where you want to register the app in the app creation manifest flow. If set, the app is registered for an organization (https://github.com/organizations/ORGANIZATION/settings/apps/new), if not set, the GitHub app would be registered for the user account (https://github.com/settings/apps/new). | | |||
There was a problem hiding this comment.
I'm not sure about the name, I think GHE stands for GitHub enterprise edition, but I'm not sure. @gr2m what does GHE actually mean?
There was a problem hiding this comment.
Then do you think it should be GH_ORG or GHE_ORG?
There was a problem hiding this comment.
yeah, good point.
I'm not sure this PR is the right approach in the first place, I'll need a moment to think about it. I comment on it soon
There was a problem hiding this comment.
Let's do GH_ORG. Sorry for the delayed response
There was a problem hiding this comment.
Thank you! I have made the change.
|
Thanks for your contribution to probot! 🎉 |
|
🎉 This PR is included in version 12.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Add support to pass, as an env variable, the organization where you want to register the app in the app creation manifest flow. If set, the app is registered for an organization (https://github.com/organizations/ORGANIZATION/settings/apps/new), if not set, the GitHub app would be registered for the user account (https://github.com/settings/apps/new).
View rendered docs/configuration.md