Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix async main function type #1672

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Conversation

kammerjaeger
Copy link
Contributor

This should better reflect the already allowed async function as main function in a probot app.

Let me know what you think.

This should better reflect the already allowed async function as main
@kammerjaeger kammerjaeger requested a review from a team as a code owner April 6, 2022 18:55
@kammerjaeger kammerjaeger changed the title fix: Allow async main function fix: Fix async main function type Apr 7, 2022
@kammerjaeger
Copy link
Contributor Author

Just a ping, what needs to be done to merge this?

@Uzlopak
Copy link
Collaborator

Uzlopak commented Nov 13, 2023

It seems correct:

await appFn(this.probotApp, {

@gr2m
@AaronDewes
target beta and merge?

@gr2m
Copy link
Contributor

gr2m commented Nov 14, 2023

@gr2m @AaronDewes target beta and merge?

Why target beta? We do support it in current Probot, or am I missing something?

await appFn(this.probotApp, {
getRouter: (path) => this.router(path),
});

@Uzlopak
Copy link
Collaborator

Uzlopak commented Nov 14, 2023

@gr2m

Yes, main is valid target.

@AaronDewes
Copy link
Member

image

@gr2m I can't merge this either, but I don't see any reason not to merge it.

@AaronDewes AaronDewes mentioned this pull request Nov 14, 2023
@AaronDewes AaronDewes merged commit fc6886d into probot:master Nov 14, 2023
2 of 11 checks passed
Copy link

🎉 This PR is included in version 12.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 13.0.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants