-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix async main function type #1672
Conversation
This should better reflect the already allowed async function as main
Just a ping, what needs to be done to merge this? |
It seems correct: Line 76 in 3219a98
@gr2m |
Why target beta? We do support it in current Probot, or am I missing something? Lines 72 to 74 in 7b09369
|
Yes, main is valid target. |
@gr2m I can't merge this either, but I don't see any reason not to merge it. |
🎉 This PR is included in version 12.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 13.0.0-beta.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This should better reflect the already allowed async function as main function in a probot app.
Let me know what you think.