fix: Make probot receive support complex Probot apps
#1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command `probot receive` fails to work when: 1. The Probot appFn is asynchronous 2. The Probot appFn requires `getRouter` The command `probot run` works fine though with the same app. This attempts to add support for these sort of Probot apps when calling `probot receive`.
moltenice
changed the title
gr2m
reviewed
Aug 2, 2022
Thanks for reviewing @gr2m Do you have a recommendation on how I'd go about testing this? I didn't see an existing test file for |
moltenice
changed the title
probot receive support complex Probot apps
|
🎉 This PR is included in version 12.2.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Oh my what a pleasant surprise when I came back from Holiday! 🎉 We're looking forward to using this in our project 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
probot receivefails to work when:getRouterThe command
probot runworks fine though with the same Probot appFn.This attempts to add support for these sorts of Probot apps when calling
probot receive.