Testing Using Nock does not work

[allout58]

Bug Report

It looks like in v8 of @octokit/requests, they switched from using Node's HTTP api, to using fetch. The latest published nock does not have support for fetch, so it does not catch the requests.

Current Behavior
As described in documentation and set up by create-probot-app, using nock does not intercept requests.

describe('My App', () => {
  test('app', () => {
    const mock = nock('https://api.github.com')
            // Test that we correctly return a test token
            .post('/app/installations/2/access_tokens')
            .reply(200, {
                token: 'test',
                permissions: {
                    metadata: 'read',
                },
            });
        await probot.receive({name: 'repository', payload});

        expect(mock.pendingMocks()).toStrictEqual([]);
  });
});

API requests get through and fail because of invalid keys, tokens, or installation IDs

Expected behavior/code

Documented examples of testing should work and not let requests through.

Environment

• Probot version(s): 13.0.2
• Node/npm version: Node 18.12.1, NPM 8.18.2
• OS: Windows 11
• Nock: 13

Possible Solution

1. Update documentation to warn that nock does not currently work. Update create-probot-app to include nock@beta
   -- or --
2. Somehow use the options.request.fetch option with a custom mock function in @octokit/request

[welcome]

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

[Uzlopak]

use nock 14 beta, which should work with native fetch.

[allout58]

I figured that out while writing this bug, but it would be nice to have it documented somewhere. Maybe I should have put this in the doc's repo, but since it also applies to the create-probot-app I thought it made more sense to put it here

[Uzlopak]

PRs are welcome. But somehow it feels wrong to document it now. If nock 14 becomes stable I would say yes.

[wolfy1339]

create-probot-app isn't up to date with the new changes from v13 yet.

[wolfy1339]

You can use node-fetch yourself if you'd like, and avoid using the built in fetch API.