Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Register github app" won't work if the field homepage isn't present in package.json #1999

Open
yuriteixeira opened this issue Apr 9, 2024 · 3 comments

Comments

@yuriteixeira
Copy link

Bug Report

Current Behavior

You'll get this very misleading error message telling that the URL field is missing in the payload, even though it is there

  1. Before pressing the button
    Screenshot 2024-04-09 at 18 08 40

  2. After
    Screenshot 2024-04-09 at 18 08 45

Expected behavior/code

It should work normally, like it does whenever I set the homepage field inside package.json.

Screenshot 2024-04-09 at 18 12 25

Environment

  • Probot version(s): v13.2.0
  • Node/npm version: v18.19.1
  • OS: 14.4.1 (23E224)
Copy link

welcome bot commented Apr 9, 2024

Thanks for opening this issue. A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

@wolfy1339
Copy link
Collaborator

That URL parameter you are seeing is for webhooks.

GitHub requires a URL (homepage) for an app in order to register

@yuriteixeira
Copy link
Author

Good to know... I probably missed that on the documentation, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants