Skip to content
This repository has been archived by the owner on Apr 29, 2022. It is now read-only.

Update to tslint-microsoft-contrib@6.0.0-beta #58

Open
joelalejandro opened this issue Nov 6, 2018 · 8 comments
Open

Update to tslint-microsoft-contrib@6.0.0-beta #58

joelalejandro opened this issue Nov 6, 2018 · 8 comments

Comments

@joelalejandro
Copy link

joelalejandro commented Nov 6, 2018

tslint-microsoft-config has released a new major version that fixes, among other things, an issue with Symbol.iterator and Symbol.asyncIterator not being supported as function names. Full release notes are here. This comment mentions that there are some breaking changes.

So, this package should update its version of tslint-microsoft-config. The question is: should it be under a major release (tslint-config-airbnb@6.0.0) due to the breaking changes of tslint-microsoft-config?

@joelalejandro joelalejandro changed the title tslint-microsoft-contrib@6.0.0-beta Update to tslint-microsoft-contrib@6.0.0-beta Nov 6, 2018
@progre
Copy link
Owner

progre commented Nov 15, 2018

Thanks for your information.

The question

I'll not update majour version of tslint-config-airbnb. because I think it's easier to understand to match with the major version of tslint.

@JoshuaKGoldberg
Copy link

One note: https://www.npmjs.com/package/tslint-microsoft-contrib/v/6.0.0 is now available and on longer in beta, if that helps at all.

@Darep
Copy link

Darep commented Dec 15, 2018

If someone wants to run 6.0.0 already, you can add a custom resolution to package.json:

{
  ...
  "resolutions": {
    "**/tslint-microsoft-contrib": "^6.0.0"
  },
  ...
}

@robgraeber
Copy link

^ To save people some time, resolutions is a field used by yarn only and not npm.

@lizzzp1
Copy link

lizzzp1 commented Feb 19, 2019

Would like this update as well, there are some accessibility additions in the update.

@TheLogan
Copy link

This seems to still be an issue?

@msegers
Copy link

msegers commented Mar 27, 2019

We're also waiting for this update. Does this require a PR? Should be fairly simple right?

msegers added a commit to msegers/tslint-config-airbnb that referenced this issue Jul 5, 2019
@dosentmatter
Copy link

I think import-name exceptions has a bug on the currently used tslint-microsoft-contrib@5.2.1. I forced it to use 6.2.0 and the error went away.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants