Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Launcher feature map shows up as indexes instead of bitmask #33444

Open
andy31415 opened this issue May 14, 2024 · 4 comments
Open

Content Launcher feature map shows up as indexes instead of bitmask #33444

andy31415 opened this issue May 14, 2024 · 4 comments
Assignees

Comments

@andy31415
Copy link
Contributor

Definition of

<bitmap name="Feature" type="bitmap32">
     <cluster code="0x050a"/>
     <field name="ContentSearch" mask="0x1"/>
     <field name="URLPlayback" mask="0x2"/>
     <field name="AdvancedSeek" mask="0x3"/>
     <field name="TextTracks" mask="0x4"/>
     <field name="AudioTracks" mask="0x5"/>
   </bitmap>

is wrong because masks should be 0x01, 0x02, 0x04, 0x08, 0x10, ... instead of using indexes. This prevented us from migrating to feature bits for these features.

If we use these, there may be sideffects. Need to update the data type and validate if there are any sideffects in code (that thinks these are indexes instead of bitmasks).

@bzbarsky-apple bzbarsky-apple changed the title Content Launcer feature map shows up as indexes instead of bitmask Content Launcher feature map shows up as indexes instead of bitmask May 14, 2024
@bzbarsky-apple
Copy link
Contributor

Looks like the buggy XML was added in #30691 @lazarkov @hawk248 @Brian-Resideo

@chrisdecenzo
Copy link
Contributor

These are not actually used in the code today, but this should be fixed to prevent future issues in case developers reference the output from these.

@bzbarsky-apple
Copy link
Contributor

These are not actually used in the code today

They're shipped in the Android and Python APIs, no? (And Darwin, but we made sure to not expose this to API consumers so far....)

@brdandu
Copy link
Contributor

brdandu commented Jun 3, 2024

We should also look into ZAP have an upgrade mechanism where things like this can be fixed. The latest ZAP can have upgrade rules to fix old .zap files opened with latest GSDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants