Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More generic completion status reconciliation #637

Open
astefanutti opened this issue Sep 19, 2023 · 1 comment
Open

More generic completion status reconciliation #637

astefanutti opened this issue Sep 19, 2023 · 1 comment

Comments

@astefanutti
Copy link
Contributor

astefanutti commented Sep 19, 2023

Name of Feature or Improvement

Improve the current mechanism that reconciles the completion status of an AppWrapper, so it supports more kind of workloads.

Description of Problem the Feature Should Solve

While the user can specify how the AppWrapper completion status is reconciled from the underlying workload, this is limited to the workload APIs that advertise a fixed completion condition in their status.

For example, it is currently not possible to reconcile the status of a RayJob, as Kuberay advertises its status in the .status.jobStatus field.

Describe the Solution You Would Like to See

The .spec.completionStatus field currently expects the name of the completion condition to look for in the underlying workload.

The behaviour of that field could be changed so it takes a JSONPath expression, e.g., .status.jobStatus == 'STOPPED' || .status.jobStatus == 'FAILED' || .status.jobStatus == 'SUCCEEDED', or a CEL based expression.

@butler54
Copy link

+1 on this one. The description in the AppWrapper schema is also inconsistent with the actual behaviour / type information:

The completionstatus field contains a list of conditions that make the associate item considered completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants