Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a metric of AppWrappers counts per state #674

Open
ronensc opened this issue Oct 31, 2023 · 0 comments · May be fixed by #675
Open

Expose a metric of AppWrappers counts per state #674

ronensc opened this issue Oct 31, 2023 · 0 comments · May be fixed by #675

Comments

@ronensc
Copy link

ronensc commented Oct 31, 2023

Name of Feature or Improvement

A metric of AppWrappers count per state

Description of Problem the Feature Should Solve

How many AppWrappers are in each state (Pending, Runing, Failed, etc.)

Describe the Solution You Would Like to See

Expose a custom Prometheus gauge metric with the real-time values.

Describe Alternatives You Have Considered

Alternatively, this data can be retrieved by querying k8s apiserver for the AppWrapper CRD. This approach is taken in https://github.com/project-codeflare/mcad-dashboard.
One advantage of using a Prometheus metric over querying the apiserver is that Prometheus metrics are being collected and stored which allows tracking how the counts change over time.

Additional Context

I'm about to submit a PR to implement this.

FYI @mamy-CS

@ronensc ronensc linked a pull request Oct 31, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant