New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent terminationGracePeriodSeconds set in different versions of calico-node daemonset #8691
Comments
I suspect the manifest value needs to be increased to match what the operator is setting, and to enable the preStop hook to run. |
Does this look like it's expected? If so, we need to adjust the manifest value to 5. |
that depends on your situation
|
I'm not sure whether setting both to positive value would be better. I guess by adding a commet above this parameter, describing the impact to node status , would be good enough. Without that, it'd be hard to imagine what happen when changing it, you have to dig out more details from source code. |
Agreed, although I would classify this as an exceptional case and far from the expected scenario in 90% of Kubernetes clusters using Calico. I think we should:
|
The calico-node daemonset has terminationGracePeriodSeconds set.
In the manifest version, it's coded as 0:
terminationGracePeriodSeconds: 0
But in the version generated by tigera-operator, it's coded as 5:
terminationGracePeriodSeconds: 5
However, both versions have prestop hook specified
If terminationGracePeriodSeconds set to 0
pre-stop hook will be unreachable, this makes the impact of calico-node deletion minimized.
If terminationGracePeriodSeconds set to non-zero
pre-stop hook will cause NetworkUnavailable status set:
and eventually cause a no-schedule taint added by kube-controller-manager:
However, I'm not sure which is the desired behavior.
Expected Behavior
terminationGracePeriodSeconds should be consistent in calico-node daemonset, both in manifest and tigera-operator-generated version.
Current Behavior
terminationGracePeriodSeconds is inconsistent in calico-node daemonset, between manifest and tigera-operator-generated version.
Possible Solution
set terminationGracePeriodSeconds to 0 in different version of calico-node daemonset
Steps to Reproduce (for bugs)
Context
I want calico installation from manifest or from tigera operator has the same behavior, in calico-node deletion.
Your Environment
The text was updated successfully, but these errors were encountered: