Fixing issues with multi-thread execution #5187
Conversation
Mzack9999
added
the
Type: Enhancement
closes #5165
Mzack9999
changed the title
There was a problem hiding this comment.
lgtm !
suggested one change about closing shared resources, apart from that i think its time for us to work on possibly removing shared global singletons so i have created a issue to track it #5239
| } | ||
| defer tmpEngine.closeInternal() | ||
| // create ephemeral nuclei objects/instances/types using base nuclei engine |
There was a problem hiding this comment.
@Mzack9999 , the tmpEngine uses shared resources like interactsh,outputwriter etc which are used by every nuclei instance created from threadsafeNucleiExecuter, while fixing memory leaks we accidently closed this here , but this is not expected to be closed here,
shared resources of threadsafeNucleiExecuter are released using .Close() of ThreadSafeNucleiEngine as for temporary resources like ratelimit and stuff they are closed using defer closeEphemeralObjects(unsafeOpts)
i have removed this in my last pr and is included in latest, so we should remove this tmpEngine.closeInternal
Proposed changes
Fixing multiple issues during usage as SDK
Checklist