goroutines leak when ExecuteNucleiWithOpts with sdk

[iuliu8899]

Nuclei version: v3.2.7

Current Behavior:

I use the threadsafe engine in sdk, and called ExecuteNucleiWithOpts func when scan start. Then...

Stack:

ratelimit.New (ratelimit.go:93) github.com/projectdiscovery/ratelimit
nuclei.createEphemeralObjects (multi.go:54) github.com/projectdiscovery/nuclei/v3/lib
nuclei.(*ThreadSafeNucleiEngine).ExecuteNucleiWithOpts (multi.go:111) github.com/projectdiscovery/nuclei/v3/lib

Everytime ExecuteNucleiWithOpts called, in createEphemeralObjects function, it New a ratelimit object and start go routine at github.com/projectdiscovery/ratelimit(ratelimit.go:93).

This go routine only return when context done, but it never called.

There is no Close() function I can use, since the object is only inside that function. (I can't use ThreadSafeNucleiEngine.Close(), it's different ratelimiter.)

Expected Behavior:

Steps To Reproduce:

Anything else:

[Mzack9999]

I'm unable to reproduce in the dev branch .If you check the block code invoking createEphemeralObjects, contextually to the creation and upon nuclei sdk complete execution also closeEphemeralObjects(..) is invoked, which in turn call the stop method of the rate limiter, that cancel the internal context. Would it be possible to provide a PoC to reproduce the behavior you are describing?

[iuliu8899]

@Mzack9999 ohhhhhh.. Yes, it closed ratelimiter... I was using the old version v3.2.2.....

Really sorry about wasting your time and thanks for your reply.