Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fluent-react/example to use latest Parcel #593

Merged
merged 2 commits into from May 4, 2022
Merged

Update fluent-react/example to use latest Parcel #593

merged 2 commits into from May 4, 2022

Conversation

eemeli
Copy link
Member

@eemeli eemeli commented May 3, 2022

Some minor example code updates to switch from Parcel v1 to v2.

@eemeli eemeli requested a review from gregtatum May 3, 2022 05:47
gregtatum
gregtatum approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look reasonable to me, I didn't test it locally. Let me know if you would like me to.

@eemeli
Copy link
Member Author

eemeli commented May 4, 2022

Thank you! No need, esp. as this is only touching example code.

@eemeli eemeli merged commit 8c2eae4 into projectfluent:master May 4, 2022
@eemeli eemeli deleted the update-example-deps branch May 4, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregtatum gregtatum gregtatum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eemeli @gregtatum