Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prometheus] - New scrape_config_files #145

Open
Birckof opened this issue Jun 13, 2023 · 2 comments · May be fixed by #292
Open

[prometheus] - New scrape_config_files #145

Birckof opened this issue Jun 13, 2023 · 2 comments · May be fixed by #292
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed roles/prometheus

Comments

@Birckof
Copy link

Birckof commented Jun 13, 2023

Starting from version 2.43.0 of Prometheus, we have a new section available in the configuration file prometheus.yml called 'scrape_config_files,' where you can specify the paths of files containing the scrape_config settings.

Would it be possible to implement this functionality by adding the 'scrape_config_files' attribute to the prometheus.yml.j2 template if it is defined in a variable, for example, 'prometheus_scrape_config_files'? It could be a list of paths."

@SuperQ
Copy link
Contributor

SuperQ commented Jun 14, 2023

Yes, that should be easy enough to add. PRs welcome.

@SuperQ SuperQ added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 14, 2023
@Birckof
Copy link
Author

Birckof commented Jun 14, 2023

Yes, that should be easy enough to add. PRs welcome.

It's good to hear that. Thanks

Right now I'm testing it, once the role is executed, I'll add a block with that parameter and my list of paths in a task using the blockinfile module of Ansible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed roles/prometheus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants