feat: bunch of improvements on blackbox_exporer #224
Conversation
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
anarcat
force-pushed
the
blackbox_exporter_binary_install_dir
branch
from
8bc2a1b
to
6a79f08
Compare
anarcat
changed the title
github-actions
bot
added
enhancement
|
|
||
| blackbox_exporter_binary_install_dir: "/usr/local/bin" | ||
| blackbox_exporter_binary_name: "blackbox_exporter" |
There was a problem hiding this comment.
I don't think we want to do this.
There was a problem hiding this comment.
could you expand on this? what exactly do we want to not do here, and why?
There was a problem hiding this comment.
I don't see any need/benefit with having the binary name customizable, we should keep the options at minimal and avoid having options just for options sake.
There was a problem hiding this comment.
this is not options option's sake: i have modified this option for it to be compatible with the debian package....
There was a problem hiding this comment.
Ah apologies. At the moment we do not support other installation methods than the binary install method that's currently in the roles.
When and if we expand that into rpm/deb/etc. packages we would definitely want the roles to install those packages, then variables such as these would most likely be populated internally in the role and not user configurable.
With that being said, such a feature would be a major change and I would first like to take care of some streamlining/deduplicating of tasks in the roles we currently have. (#64 )
There was a problem hiding this comment.
ah. well, i guess one thing i'm saying is you're almost there and you just need to use the right binary name here. i've deployed prom on a debian 12 host using this playbook and it kind of worked after the bunch of patches i had to roll here...
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
This is for backwards compatibility with Debian packages. Signed-off-by: Antoine Beaupré <anarcat@debian.org>
Signed-off-by: Antoine Beaupré <anarcat@debian.org>
anarcat
force-pushed
the
blackbox_exporter_binary_install_dir
branch
from
6a79f08
to
f1d810d
Compare
github-actions
bot
added
enhancement
This puts the config file in
/etc/prometheus, allows changes to the binary name (so we can use the Debian package directly).Closes: #178