Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smartctl exporter role: the default user and group should be root #298

Open
kennethso168 opened this issue Feb 21, 2024 · 1 comment
Open

Comments

@kennethso168
Copy link

kennethso168 commented Feb 21, 2024

Just tried out the smartctl exporter role without further configuration and it didn't work. It works after setting smartctl_exporter_system_user and smartctl_exporter_system_group to root.

From prometheus-community/smartctl_exporter#146, the upstream package is intended to be run as root, and the provided SystemD unit files in the upstream package are configured to have root as the user as well. There is some extra steps required in order to allow non-root users to run the exporter.

Therefore, I would suggest changing the defaults to smartctl_exporter_system_user and smartctl_exporter_system_group to root for a better out-of-the-box experience

@gardar
Copy link
Member

gardar commented Feb 23, 2024

Good point!
I like the systemd unit in the AUR package, perhaps we should base the one in the role on that.

With that being said, we should absolutely try to catch issues like this in the molecule tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants