Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Metric Type for elasticsearch_data_stream_store_size_bytes #797

Open
b2ronn opened this issue Oct 22, 2023 · 0 comments
Open

Incorrect Metric Type for elasticsearch_data_stream_store_size_bytes #797

b2ronn opened this issue Oct 22, 2023 · 0 comments

Comments

@b2ronn
Copy link

b2ronn commented Oct 22, 2023

I have noticed a potential issue with the metric elasticsearch_data_stream_store_size_bytes in the codebase. According to my understanding, this metric should be classified as a Gauge, but in the code, it is specified as CounterValue. This discrepancy in the metric type could lead to incorrect monitoring and interpretation of data stream store size.

			{
				Type: prometheus.CounterValue,
				Desc: prometheus.NewDesc(
					prometheus.BuildFQName(namespace, "data_stream", "store_size_bytes"),
					"Store size of data stream",
					defaultDataStreamLabels, nil,
				),
				Value: func(dataStreamStats DataStreamStatsDataStream) float64 {
					return float64(dataStreamStats.StoreSizeBytes)
				},
				Labels: defaultDataStreamLabelValues,
			},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant