Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] upgrade grafana dashboards from AngularJS to the new panels #4380

Closed
dmpe opened this issue Mar 22, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@dmpe
Copy link

dmpe commented Mar 22, 2024

Is your feature request related to a problem ?

Grafana dashboards need to be updated/refreshed in https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack/templates/grafana/dashboards-1.14.

Reason being is that AngularJS panels are being deprecated https://grafana.com/docs/grafana/latest/developers/angular_deprecation/

Describe the solution you'd like.

Please use new panels which are not dependant on angularJS.

E.g. graph panel becomes time-series ? table is still called table in the new grafana

Describe alternatives you've considered.

N/A - sure [angular_support_enabled](https://github.com/grafana/grafana/blob/d61bcdf4ca5e69489e0067c56fbe7f0bfdf84ee4/conf/defaults.ini#L362) would be possible to use, but question is for how long...

Additional context.

No response

@dmpe dmpe added the enhancement New feature or request label Mar 22, 2024
@wykhuh
Copy link

wykhuh commented Mar 22, 2024

I was testing out kube-prometheus-stack this week and noticed the AngularJS depreciation warning too.

@long2ice
Copy link

Same here

@dmpe
Copy link
Author

dmpe commented Mar 23, 2024

Actually, this issue has already been reported to the upstream project -> kubernetes-monitoring/kubernetes-mixin#898. I.e it is still relevant insofar as, after the upstream change, grafana dashboards need to be updated here as well..

cc @jkroepke

@jkroepke
Copy link
Member

You can set angular_support_enabled=false, then Grafana will auto convert deprecated panels.

However, upstream must be upgrade everything, since we only depend on them.

@vfarcic
Copy link

vfarcic commented Mar 31, 2024

Was this completed? The Angular warning is still there.

@ArtemGontar
Copy link

So, is that planned or not planned, or fixed?

I am confused

@jkroepke
Copy link
Member

So, is that planned or not planned, or fixed?

I am confused

In general, it's not planned. There reason for this is that is not development at kube-prometheus-stack in terms of Grafana Dashboards & Prometheus Rules.

The majority comes from https://github.com/kubernetes-monitoring/kubernetes-mixin and there is an going issue to track this: kubernetes-monitoring/kubernetes-mixin#898

For example: kubernetes-monitoring/kubernetes-mixin#904

The dashboards needs to be upgrade there. Once it's done, we are able to update them at kube-prometheus-stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants